Potential network split when individual tx used as coinbase?

2 messages, 5 May 2012. Started by Rebroad (sourceforge).

Rebroad (sourceforge), Pieter Wuille

Rebroad (sourceforge) 5 May 2012, 08:31 UTC permalink original

Hi,

Quoted text (2 lines)

>
>

Looking at: https://github.com/bitcoin/bitcoin/commit/3e52aaf2121d597ab1ed012b65e37f9cb5f2754e#src/main.cpp-P52

It appears that 8 months ago the code was changed to DoS(100) nodes sending on txs that use individual txs as the coinbase. Does this mean txs that are 0 confirmed?

If so, then, is this a risk of a network split, as I'm sure I've read about services popping up using bitcoin that are specifically allowing 0 confirmed transactions, and therefore there must be peers around that accept these.

Or have I misread the code?

Cheers, Ed

PS. Would a BIP have been applicable for the above-mentioned change?

Pieter Wuille 5 May 2012, 11:40 UTC in reply to Rebroad (sourceforge) permalink original

On Sat, May 05, 2012 at 09:31:39AM +0100, Rebroad (sourceforge) wrote:

Quoted text (11 lines)

> Hi,
> >
> >
> Looking at:
> https://github.com/bitcoin/bitcoin/commit/3e52aaf2121d597ab1ed012b65e37f9cb5f2754e#src/main.cpp-P52
>
> It appears that 8 months ago the code was changed to DoS(100) nodes sending
> on txs that use individual txs as the coinbase. Does this mean txs that are
> 0 confirmed?
>
> Or have I misread the code?

I think so, see my comment there.