Roadmap for autotools / Qt gui merge
12 messages, 17 to 22 Jun 2011. Started by John Smith.
Pieter Wuille (3), Luke Dashjr (3), John Smith, Brendan Molloy, Douglas Huff, Gavin Andresen, Jeff Garzik, Mark Visser
Hello,
I think my Qt GUI is pretty much ready for merging. I've been using it for a while and all functionality works.
What is the current roadmap for including the autotools build system, so that it will be possible to support multiple GUIs? 0.4.0?
JS
Is there a link to this GUI code?
John Smith wrote:
Quoted text (21 lines)
> Hello, > > I think my Qt GUI is pretty much ready for merging. I've been using it for a > while and all functionality works. > > What is the current roadmap for including the autotools build system, so > that it will be possible to support multiple GUIs? 0.4.0? > > JS > > > ------------------------------------------------------------------------------ > EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists•sourceforge•net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development
On Fri, Jun 17, 2011 at 06:42:30AM +0000, John Smith wrote:
Quoted text (7 lines)
> Hello, > > I think my Qt GUI is pretty much ready for merging. I've been using it for a > while and all functionality works. > > What is the current roadmap for including the autotools build system, so > that it will be possible to support multiple GUIs? 0.4.0?
I'm in favor of merging autotools now, unless there are still known issues with it, such as mingw32 compatibility?
If the Qt port is functionally complete and stable, I'd vote to have it merged as well under these conditions: * the changes to the 'core' are minimal/trivial * marked as 'experimental', and not enabled by default
The only disadvantage of another GUI is that the (necessary) cleanup of RPC/GUI code will now need makes changes in 3 places instead of 2, but as I understand it, there are much more people willing to work on Qt code than on wx code?
On Friday, June 17, 2011 6:31:25 AM Pieter Wuille wrote:
Quoted text (4 lines)
> The only disadvantage of another GUI is that the (necessary) cleanup of > RPC/GUI code will now need makes changes in 3 places instead of 2, but as > I understand it, there are much more people willing to work on Qt code > than on wx code?
I'm not sure the Wallet protocol implementation needs to touch the GUI code at all, except when porting the GUI to use it. Therefore, if the code is already written, I don't see any harm in merging it.
Agreed. The sooner qt gets merged the sooner real GUI improvements will be made. On Jun 17, 2011 8:30 AM, "Luke-Jr" <luke@dashjr•org> wrote:
Quoted text (7 lines)
> On Friday, June 17, 2011 6:31:25 AM Pieter Wuille wrote: >> The only disadvantage of another GUI is that the (necessary) cleanup of >> RPC/GUI code will now need makes changes in 3 places instead of 2, but as >> I understand it, there are much more people willing to work on Qt code >> than on wx code? > > I'm not sure the Wallet protocol implementation needs to touch the GUI
code at
Quoted text (1 line)
> all, except when porting the GUI to use it. Therefore, if the code is
already
Quoted text (3 lines)
> written, I don't see any harm in merging it. > >
------------------------------------------------------------------------------
Quoted text (8 lines)
> EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists•sourceforge•net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development
I'm in favor of dropping the wxWidgets GUI and replacing it with a Qt GUI. I think supporting more than one GUI for the reference client is a bad idea.
Qt is LGPL, so license for that is not an issue. John, you willing to release your code under the bitcoin MIT license?
Everybody else: anybody object to replacing "the devil we know" (wxWidgets) with Qt?
On Friday, June 17, 2011 12:27:22 PM Gavin Andresen wrote:
Quoted text (9 lines)
> I'm in favor of dropping the wxWidgets GUI and replacing it with a Qt > GUI. I think supporting more than one GUI for the reference client is > a bad idea. > > Qt is LGPL, so license for that is not an issue. > John, you willing to release your code under the bitcoin MIT license? > > Everybody else: anybody object to replacing "the devil we know" > (wxWidgets) with Qt?
So long as we can get a solid name for it. Obviously I can't continue to call it wxBitcoin if it's strictly Qt...
On Fri, Jun 17, 2011 at 4:37 PM, Luke-Jr <luke@dashjr•org> wrote:
Quoted text (2 lines)
> So long as we can get a solid name for it. Obviously I can't continue to call > it wxBitcoin if it's strictly Qt...
I've started calling the github/bitcoin/bitcoin.git the Satoshi Client, GUI or not.
On Fri, Jun 17, 2011 at 06:42:30AM +0000, John Smith wrote:
Quoted text (7 lines)
> Hello, > > I think my Qt GUI is pretty much ready for merging. I've been using it for a > while and all functionality works. > > What is the current roadmap for including the autotools build system, so > that it will be possible to support multiple GUIs? 0.4.0?
The consensus seems to be to merge autotools and qtgui. However, autotools is apparently not tested (enough) on native windows and osx platforms.
Anyone on this list with either development environnement, and willingness to test?
On Friday, June 17, 2011 2:42:30 AM John Smith wrote:
Quoted text (2 lines)
> I think my Qt GUI is pretty much ready for merging. I've been using it for > a while and all functionality works.
Before this gets merged, I'd like to check: does it work ok if Qt is built without glib support?
Hi everyone,
I spent some time today with the bitcoin-qt client and autotools on mac. The qt client builds and runs with a few small changes (mostly just #including boost/filesystem/operations.hpp in a few places).
Autotools + qt will take a bit longer. I've got something *almost* working, but I won't have a chance to finish it for the rest of the week. I'll push the changes to github tomorrow (Monday) so anyone else can take a crack at it if they so wish.
cheers, -Mark
On 2011-06-18, at 8:30 PM, Pieter Wuille wrote:
Quoted text (28 lines)
> On Fri, Jun 17, 2011 at 06:42:30AM +0000, John Smith wrote: >> Hello, >> >> I think my Qt GUI is pretty much ready for merging. I've been using it for a >> while and all functionality works. >> >> What is the current roadmap for including the autotools build system, so >> that it will be possible to support multiple GUIs? 0.4.0? > > The consensus seems to be to merge autotools and qtgui. However, autotools is > apparently not tested (enough) on native windows and osx platforms. > > Anyone on this list with either development environnement, and willingness > to test? > > -- > Pieter > > > ------------------------------------------------------------------------------ > EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists•sourceforge•net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development
On Sun, Jun 19, 2011 at 02:30:49AM +0200, Pieter Wuille wrote:
Quoted text (5 lines)
> The consensus seems to be to merge autotools and qtgui. However, autotools is > apparently not tested (enough) on native windows and osx platforms. > > Anyone on this list with either development environnement, and willingness > to test?
Jaromil has his autotools branch rebased against git master, and included Mark's NOSIGPIPE/NOSIGNAL patch (needs a commit summary, though).
Can people test this compiles+works on several systems (ubuntu, fedora(?), mingw crosscompile, osx, ...)?
See https://github.com/jaromil/bitcoin/commits/autotools3
For me, it works on Ubuntu 10.10 amd64, including wx gui.