LearnBitcoin

Bitcoin Dev Archive 2014

Process for getting a patch aproved?

3 messages, 5 to 6 Mar 2014. Started by Kevin.

Kevin, Greg Maxwell, Wladimir J. van der Laan

Permalink Original thread on gnusha.org

Kevin permalink original

Hello. How would I submit a patch? Could it be sent through the list as an attachment?

Greg Maxwell in reply to Kevin permalink original

On Wed, Mar 5, 2014 at 2:17 PM, Kevin <kevinsisco61784@gmail•com> wrote:

Quoted text (2 lines)
> Hello.  How would I submit a patch?  Could it be sent through the list
> as an attachment?

To the reference software? Normally you'd open a github account and submit there.

Though if for some reason you can't— though its strongly preferred— sending a git-format-patch via email might be an acceptable fallback.

Wladimir J. van der Laan in reply to Kevin permalink original

On Wed, Mar 5, 2014 at 11:17 PM, Kevin <kevinsisco61784@gmail•com> wrote:

Quoted text (3 lines)
> Hello.  How would I submit a patch?  Could it be sent through the list
> as an attachment?
>

You can, but as reviewing can take a while, the github model works better for this project.

In my experience people lose track of patches sent to mailing lists, at least when posted to github there will be a nagging 'issue' appearing until it is either merged or closed otherwise.

If it concerns a proposed protocol change do discuss it on the mailing list, as people building other implementations read here and not on github.

Wladimir