0.7.1 release

3 messages, 3 Oct 2012. Started by Gavin Andresen.

Gavin Andresen, Wladimir J. van der Laan, Jeff Garzik

Bitcoin Core releases

Gavin Andresen 3 Oct 2012, 17:49 UTC permalink original

There is consensus that we need to do a 0.7.1 release to fix the "click on a bitcoin: URI and nothing happens" bug on Windows.

I would really like to fix the "I upgraded from a binary running an incompatible version of BDB and now I get a DB_RUNRECOVERY error on startup" problem, too, and I've got a pull request that fixes half of that problem (plus a bunch of other "my wallet is broken" cases):

"Handle corrupt wallets gracefully" : https://github.com/bitcoin/bitcoin/pull/1895

This pull request:

"Add -reindex, to perform in-place reindexing of blockchain data files" : https://github.com/bitcoin/bitcoin/pull/1870

... could be the basis for fixing the other half of the problem (if blkindex.dat is bad, delete it and re-create it from the blk000?.dat files).

Are there any other very-high-priority pull requests that should go into a 0.7.1 release?

I'd like to pull:

"P2P: Do not request blocks from peers with fewer blocks than us" : https://github.com/bitcoin/bitcoin/pull/1834 "In listaddressgroupings push down the IsMine check to run on each input." : https://github.com/bitcoin/bitcoin/pull/1872

... and these which could be considered fixes to the new raw transactions API:

"Add redeemScript to raw transactions API" : https://github.com/bitcoin/bitcoin/pull/1818 "Add new RPC "lockunspent", to prevent spending of selected outputs" : https://github.com/bitcoin/bitcoin/pull/1861

Wladimir J. van der Laan 3 Oct 2012, 18:49 UTC in reply to Gavin Andresen permalink original

On Wed, Oct 3, 2012 at 7:49 PM, Gavin Andresen <gavinandresen@gmail•com> wrote:

Quoted text (5 lines)

> There is consensus that we need to do a 0.7.1 release to fix the
> "click on a bitcoin: URI and nothing happens" bug on Windows.
>
> "Handle corrupt wallets gracefully" :
> https://github.com/bitcoin/bitcoin/pull/1895

We definitely need that one in.

Quoted text (5 lines)

>
> This pull request:
>
> "Add -reindex, to perform in-place reindexing of blockchain data
> files" : https://github.com/bitcoin/bitcoin/pull/1870

Agreed

Quoted text (3 lines)

>
> Are there any other very-high-priority pull requests that should go
> into a 0.7.1 release?

I think we should also pull #1859 "add LOCK() for proxy related data-structures" Missing synchronization primitives are a sure way to get reports about random crashes.

The rest can wait.

Wladimir

Jeff Garzik 3 Oct 2012, 19:53 UTC in reply to Gavin Andresen permalink original

On Wed, Oct 3, 2012 at 1:49 PM, Gavin Andresen <gavinandresen@gmail•com> wrote:

Quoted text (2 lines)

> "Add -reindex, to perform in-place reindexing of blockchain data
> files" : https://github.com/bitcoin/bitcoin/pull/1870

Agree, though needs testing

Quoted text (2 lines)

> "P2P: Do not request blocks from peers with fewer blocks than us" :
> https://github.com/bitcoin/bitcoin/pull/1834

Agree

Quoted text (2 lines)

> "Add new RPC "lockunspent", to prevent spending of selected outputs" :
> https://github.com/bitcoin/bitcoin/pull/1861

Agree, though sipa raised a valid issue. lockunspent, like the existing listunspent, is wallet based.

As raw transactions might spend outputs _not_ in the wallet, lockunspent would miss those.

I think this is OK, because listunspent is already wallet-based, but it should be noted.